Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep pytest-interface-tester<2 #70

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Keep pytest-interface-tester<2 #70

merged 2 commits into from
Jan 26, 2024

Conversation

mmkay
Copy link
Contributor

@mmkay mmkay commented Jan 26, 2024

Overview

As pytest-interface-tester#13 upgrades pydantic to v2, limit interface tester dependency to <2 until the project decides to switch to pydantic v2.

Rationale

We're moving to pydantic v2 in observability charms so interface-tester needs to be upgraded as well.

Juju Events Changes

None.

Module Changes

None.

Library Changes

Only thing that changes is the dependency definition for interface tests.

Checklist

No updates in the documentation. Looks like as a non-maintainer I can't tag PRs?

@mmkay mmkay requested a review from a team as a code owner January 26, 2024 09:21
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@arturo-seijas
Copy link
Collaborator

/canonical/self-hosted-runners/run-workflows a481544

@arturo-seijas
Copy link
Collaborator

/canonical/self-hosted-runners/run-workflows e68cbe9

Copy link
Contributor

Test coverage for e68cbe9

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
lib/charms/saml_integrator/v0/saml.py      89      0     16      0   100%
src/charm.py                               43      1      4      0    98%   60
src/charm_state.py                         33      0      4      0   100%
src/saml.py                                63      0     10      0   100%
-----------------------------------------------------------------------------------
TOTAL                                     228      1     34      0    99%

Static code analysis report

Run started:2024-01-26 12:41:00.760007

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1009
  Total lines skipped (#nosec): 5
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 9f36436 into canonical:main Jan 26, 2024
20 checks passed
@mmkay mmkay deleted the pin-pytest-interface-tester branch January 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants