[DPE-3331][GCS] Add service account credentials #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phvalguima
changed the title
welpaolo
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
LGTM :)
I have few comments:
- Please open a PR against the Charm Interface repository to get your changes in the interface approved.
- Please do an empty commit to trigger CI
- I will suggest you to wait for this PR to be approved and apply the same changes for the service account field.
phvalguima
changed the base branch from
main
to
DPE-3198-Stop-printing-secrets-to-STDOUT
phvalguima
force-pushed
the
add-service-account
branch
from
7efcf3f to
5b46fee
Compare
|
Hi @welpaolo thanks for your review. I actually rebased this change onto that PR. @a-velasco can you review as well? |
Base automatically changed from
DPE-3198-Stop-printing-secrets-to-STDOUT
to
main
January 29, 2024 10:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some public clouds support service accounts instead of access_/secret_key. GCP is one example.
This PR adds service account credential support to the s3 integrator.
This PR is related to: canonical/charm-relation-interfaces#135