Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default service for the Hello world example #330

Closed
wants to merge 1 commit into from

Conversation

valentincanonical
Copy link
Contributor

@valentincanonical valentincanonical commented Jul 19, 2023

Provide a default service for the Hello world example. Should probably be done with other examples as well.

  • Have you signed the CLA?

Provide a default service for the Hello world example
@cjdcordeiro
Copy link
Collaborator

this is a bit controversial.

Pebble services do not support one-shot commands like hello, thus why such examples don't have any services. It is completely fine to have a ROCK without any pebble services, if the desired execution mode is leveraging one-shot instructions via pebble exec. having short-lived commands associated with pebble services will cause ROCKs to behave in a weird way since pebble's service restart policies and health checks will be ignored (cause the service won't live for enough time).

Useful reference:

PS.: I do think we should support this though, but it is something that needs to be changed on the Pebble side.

@cjdcordeiro cjdcordeiro added the documentation Improvements or additions to documentation label Jul 27, 2023
@sergiusens
Copy link
Collaborator

closing until controversy is resolved

@sergiusens sergiusens closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants