Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change owners to maintainers #22

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

IronCore864
Copy link
Collaborator

Per discussions in this issue (see comment here and here) and an email thread, we have agreed to the followings:

  • Use "maintainers" instead of "owners", because "owners" indicates ownership while the interface is meant to be "owned" by a group around it.
  • Put a GitHub team ID as "maintainers", instead of a list of users. This eliminates the overhead of maintaining the list of user IDs. The purpose of this field is to assign issues to users when a certain interface test fails; although it's not supported to assign an issue to a team, this can be worked out in the charm-relation-interfaces repo's run_matrix.py script.

This PR to pytest-interface-tester reflects the above changes.

See the other part of the change in the charm-relation-interfaces repo.

An extra note on the version: It has not been used since the last release, 3.1.0. So, although this PR technically is a breaking change, it doesn’t break anything. That’s why I only slightly bumped the version to 3.1.1, not strictly following the SEMVER rules.

Copy link
Collaborator

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo a minor consistency nit

interface_tester/collector.py Outdated Show resolved Hide resolved
interface_tester/collector.py Outdated Show resolved Hide resolved
@IronCore864
Copy link
Collaborator Author

Refactored, please go ahead and merge. Thanks!

@PietroPasotti PietroPasotti merged commit d86bb2a into canonical:main Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants