-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename charms.yaml file to interface.yaml #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I'm not super familiar with this.
In regards to the version question, if we're not going to support both names, then a major bump seems the correct thing to do. It allows pinning to work as expected.
Note that you do need to have the version change in some way, because there's a workflow that does a release on merge to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As for the version bump, I think we're the only ones depending on this so probably we could get away with a minor bump without breaking anyone's code, but still, my personal philosophy is: versions are free. So let's give it a major bump for the sake of hygiene :)
Thanks all for the review, I have fixed the naming and bumped the version to 3.0.0 in |
A gentle reminder: Could you please merge it? @PietroPasotti I don't have permission for this repo. Thanks! |
Sorry! was on holiday some time :) |
In "overhaul to better support charmhub's interface pages", all
charms.yaml
are renamed tointerface.yaml
. Updatepytest-interface-tester
to loadinterface.yaml
instead ofcharms.yaml
.See more discussion here.
Manual tests are done by installing this package from local path:
Note: We probably need to release a new version for this module but I'm not sure about the version: It's a breaking change, so by SEMVER it shouldn't be v2.0.2, although it seems "right" since it's a minor change... I left the version string in
pyproject.toml
unchanged, still 2.0.1 now.