Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Clean-up duplicated Patroni config reloads #682

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

sinclert-canonical
Copy link
Contributor

This PR removes unnecessary calls to reload_patroni_configuration method, in cases where the charm's update_config method is explicitly called right before such line. This method already reloads the Patroni configuration internally (reference), so it does not make sense to preserve these lines.


This discovery was done thanks to the help of @lucasgameiroborges

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.74%. Comparing base (58fc973) to head (3111380).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   71.79%   71.74%   -0.06%     
==========================================
  Files          13       13              
  Lines        3216     3210       -6     
  Branches      478      475       -3     
==========================================
- Hits         2309     2303       -6     
  Misses        791      791              
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sinclert-canonical sinclert-canonical force-pushed the sinclert/backups-cleanup branch 2 times, most recently from bd49b20 to f7de0c0 Compare November 25, 2024 16:00
@sinclert-canonical sinclert-canonical marked this pull request as ready for review November 25, 2024 16:57
Copy link
Member

@lucasgameiroborges lucasgameiroborges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Failing tests are known issues, no relation with your changes.

@sinclert-canonical sinclert-canonical changed the title Clean-up duplicated Patroni config reloads [MISC] Clean-up duplicated Patroni config reloads Nov 27, 2024
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sinclert-canonical sinclert-canonical merged commit b6b631f into main Nov 27, 2024
97 checks passed
@sinclert-canonical sinclert-canonical deleted the sinclert/backups-cleanup branch November 27, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants