build: use the Charmcraft poetry plugin #652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be dropped once charmcraft 3.3 is released.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 71.23% 71.23%
=======================================
Files 12 12
Lines 3091 3091
Branches 471 471
=======================================
Hits 2202 2202
Misses 777 777
Partials 112 112 ☔ View full report in Codecov by Sentry. |
|
Hi @lengau! Thanks for the contribution. Do you already want us to review this PR? I see that it's still in draft. |
|
@marceloneppel this will only be usable once Charmcraft 3.3 is out - I'll take it out of draft then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies charmcraft.yaml to use Charmcraft 3.3's
poetryplugin for building the charm.The charm is currently bigger due to duplicated files (see: canonical/charmcraft#1966), but will be ~5 MiB smaller than the original once that's fixed, mostly due to not vendoring
pip.