[DPE-5324] Increase linting rules #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 71.23% 71.46% +0.22%
==========================================
Files 12 12
Lines 3091 3073 -18
Branches 471 461 -10
==========================================
- Hits 2202 2196 -6
+ Misses 777 767 -10
+ Partials 112 110 -2 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Oct 17, 2024
| @@ -100,13 +100,13 @@ target-version = ["py38"] | |||
| [tool.ruff] | |||
| # preview and explicit preview are enabled for CPY001 | |||
| preview = true | |||
| target-version = "py38" | |||
| target-version = "py310" | |||
There was a problem hiding this comment.
No libs or focal, so it is safe.
dragomirp
commented
Oct 17, 2024
Comment on lines
+52
to
+53
| PATRONI_TIMEOUT = 10 | ||
|
|
There was a problem hiding this comment.
Bandit rules want timeouts for HTTP calls.
dragomirp
commented
Oct 17, 2024
Comment on lines
+89
to
+90
| # File shouldn't close | ||
| stdout=open(LOG_FILE_PATH, "a"), # noqa: SIM115 |
There was a problem hiding this comment.
We should most probably set the output in the running instance instead or switch to a proper service.
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
marceloneppel
approved these changes
Oct 17, 2024
taurus-forever
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more linting rules and change and suppress the reported issues. Added rules are: