Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5601] Add pgBackRest logrotate configuration #645

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Oct 14, 2024

Issue

pgBackRest logs are not rotated.

Solution

Rotate the logs by using logrotate and following the rule we have for other logs: rotate every minute.

A background process was created for that job.

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (037d1bb) to head (bc61694).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/rotate_logs.py 85.29% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   71.46%   71.68%   +0.22%     
==========================================
  Files          12       13       +1     
  Lines        3073     3115      +42     
  Branches      461      465       +4     
==========================================
+ Hits         2196     2233      +37     
- Misses        767      771       +4     
- Partials      110      111       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel marked this pull request as ready for review October 17, 2024 03:23
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx!

@marceloneppel marceloneppel merged commit 685d78c into main Oct 19, 2024
97 checks passed
@marceloneppel marceloneppel deleted the dpe-5601-rotate-pgbackrest-logs branch October 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants