Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4816] Add jinja2 as a dependency #520

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

dragomirp
Copy link
Contributor

Make sure the charm has jinja2 installed

Related to #519

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (7299748) to head (54084df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   68.68%   68.68%           
=======================================
  Files          11       11           
  Lines        3015     3015           
  Branches      535      535           
=======================================
  Hits         2071     2071           
  Misses        823      823           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp marked this pull request as ready for review July 3, 2024 12:57
Copy link
Member

@lucasgameiroborges lucasgameiroborges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Who knows how many other packages we just expect to exist in the host system, like this one? Is there a way of reliably check this kind of thing? maybe on CI?

@dragomirp
Copy link
Contributor Author

Who knows how many other packages we just expect to exist in the host system, like this one? Is there a way of reliably check this kind of thing? maybe on CI?

I think jinja was a known and special case, but I can't remember why we kept on using the system installed one.

@dragomirp dragomirp merged commit 3f061fa into main Jul 10, 2024
78 of 79 checks passed
@dragomirp dragomirp deleted the dpe-4816-missing-jinja branch July 10, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants