-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4816] Add jinja2 as a dependency #520
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 68.68% 68.68%
=======================================
Files 11 11
Lines 3015 3015
Branches 535 535
=======================================
Hits 2071 2071
Misses 823 823
Partials 121 121 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Who knows how many other packages we just expect to exist in the host system, like this one? Is there a way of reliably check this kind of thing? maybe on CI?
I think jinja was a known and special case, but I can't remember why we kept on using the system installed one. |
Make sure the charm has jinja2 installed
Related to #519