-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Suppress oversee user action #509
base: main
Are you sure you want to change the base?
Conversation
@dragomirp abandon due to #507 ? |
It's a continuation if we decide to add the action at some point. I will rebase once #507 gets merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 69.72% 69.81% +0.09%
==========================================
Files 11 11
Lines 2870 2879 +9
Branches 508 510 +2
==========================================
+ Hits 2001 2010 +9
Misses 763 763
Partials 106 106 ☔ View full report in Codecov by Sentry. |
reenable-oversee-users: | ||
description: Reenable purging of managed credentials after a standby cluster is promoted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why it is not run as part of promote-to-primary
action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original issue was the promoting the replica cluster deleted users for relations to the old primary cluster, since there were no relations for them in the new primary cluster. We can't know if the client charms got rerelated to the new primary cluster, so we can't know when it's safe to reenable that functionality without user input.
No description provided.