Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4544] Fix model switch #483

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Jun 3, 2024

Issue

While setting the architecture constraints for the second model in the async replication tests through #464, it was missed to switch the model back to the first model. It caused issues because the juju offer command needed to be run in the first model on those tests.

FAILED tests/integration/ha_tests/test_async_replication.py::test_async_replication - juju.errors.JujuAPIError: application "async-primary" not found

This issue is blocking tests from passing on the main branch.

Solution

Switch the model back to the first model after setting the architecture constraints in the second model.

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how the test passed in AMD before enabling ARM... but LGTM.

Copy link
Member

@lucasgameiroborges lucasgameiroborges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marceloneppel
Copy link
Member Author

I am not sure how the test passed in AMD before enabling ARM... but LGTM.

Before enabling ARM, we didn't have the first juju switch call (used to set the model constraints when in ARM), which caused the issue.

@marceloneppel marceloneppel merged commit 16d10d8 into main Jun 4, 2024
90 checks passed
@marceloneppel marceloneppel deleted the dpe-4544-fix-model-switch branch June 4, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants