-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4257] Async replication UX Improvements #481
[DPE-4257] Async replication UX Improvements #481
Conversation
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-ux-improvements Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's merge edge and promote candidate to complete testing while waiting for feedback.
…ation-ux-improvements Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-ux-improvements Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
- Coverage 71.06% 69.21% -1.86%
==========================================
Files 11 11
Lines 2779 2865 +86
Branches 487 507 +20
==========================================
+ Hits 1975 1983 +8
- Misses 706 781 +75
- Partials 98 101 +3 ☔ View full report in Codecov by Sentry. |
…ation-ux-improvements Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-ux-improvements Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Issue
The async replication UX between PostgreSQL and MySQL charms doesn't match.
The failover operation (
promote-to-primary force=true
) action is not working correctly, i.e. it's not checking if the other cluster is not reachable.Also, it's not possible to update passwords when the consumer side is the primary cluster.
Solution
Sync the implementation with what was agreed (column G from https://docs.google.com/spreadsheets/d/1viBdDXmpkE98auo2YbFPP_RWzyHLyjXAf6oe7Fwszok/edit#gid=0).
How to test:
Additional tests will be added in the follow-up ticket: https://warthogs.atlassian.net/browse/DPE-4538
Port of canonical/postgresql-k8s-operator#491.