Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4257] Async replication UX Improvements #481

Merged
merged 12 commits into from
Jun 18, 2024

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented May 29, 2024

Issue

The async replication UX between PostgreSQL and MySQL charms doesn't match.

The failover operation (promote-to-primary force=true) action is not working correctly, i.e. it's not checking if the other cluster is not reachable.

Also, it's not possible to update passwords when the consumer side is the primary cluster.

Solution

Sync the implementation with what was agreed (column G from https://docs.google.com/spreadsheets/d/1viBdDXmpkE98auo2YbFPP_RWzyHLyjXAf6oe7Fwszok/edit#gid=0).

How to test:

Additional tests will be added in the follow-up ticket: https://warthogs.atlassian.net/browse/DPE-4538

Port of canonical/postgresql-k8s-operator#491.

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-ux-improvements

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel marked this pull request as ready for review May 31, 2024 20:07
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge edge and promote candidate to complete testing while waiting for feedback.

…ation-ux-improvements

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-ux-improvements

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 18.00000% with 123 lines in your changes missing coverage. Please review.

Project coverage is 69.21%. Comparing base (7c306c8) to head (9ee81a1).

Files Patch % Lines
src/relations/async_replication.py 12.80% 109 Missing ⚠️
src/charm.py 40.00% 10 Missing and 2 partials ⚠️
src/cluster.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   71.06%   69.21%   -1.86%     
==========================================
  Files          11       11              
  Lines        2779     2865      +86     
  Branches      487      507      +20     
==========================================
+ Hits         1975     1983       +8     
- Misses        706      781      +75     
- Partials       98      101       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ation-ux-improvements

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-ux-improvements

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel merged commit 1a1c2d4 into main Jun 18, 2024
51 of 53 checks passed
@marceloneppel marceloneppel deleted the dpe-4257-async-replication-ux-improvements branch June 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants