[MISC] Update snap and renovate fixes #432
Conversation
dragomirp
changed the title
| @@ -51,10 +51,10 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| juju: | |||
| - agent: 2.9.46 | |||
| libjuju: ^2 | |||
| - agent: 2.9.46 # renovate: latest juju 2 | |||
There was a problem hiding this comment.
The backup tests fail on 2.9.47. Charm cannot be redeployed with the same name.
There was a problem hiding this comment.
This seems to be fixed with juju 2.9.49, but there are issues with the subordinates test. I will update in a separate PR.
There was a problem hiding this comment.
I cannot find such fixes mentioned in Juju 2.9.47+ release notes: https://discourse.charmhub.io/t/roadmap-releases/5064
Maybe this... strange... Will ask Juju Team to improve release notes as 2.9.48 is missing there completely.
| try: | ||
| return self.update_config() | ||
| except Exception: | ||
| logger.exception("TLS files failed to push. Error in config update") | ||
| return False |
There was a problem hiding this comment.
We don't really check for exceptions or return value of update_config() in most places, we should most probably go over and handle such cases.
There was a problem hiding this comment.
Yeah.... this is what we saw with @beliaev-maksim yesterday on a troubleshooting. Tnx for the quick fix here!
| unit = ops_test.model.units.get(f"{database_app_name}/0") | ||
| await ops_test.model.block_until( | ||
| lambda: unit.workload_status_message == ANOTHER_CLUSTER_REPOSITORY_ERROR_MESSAGE | ||
| ) |
There was a problem hiding this comment.
Model fails to idle with the new snap. I tried with one minute ffwd interval, but it didn't help.
| @@ -51,10 +51,10 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| juju: | |||
| - agent: 2.9.46 | |||
| libjuju: ^2 | |||
| - agent: 2.9.46 # renovate: latest juju 2 | |||
There was a problem hiding this comment.
I cannot find such fixes mentioned in Juju 2.9.47+ release notes: https://discourse.charmhub.io/t/roadmap-releases/5064
Maybe this... strange... Will ask Juju Team to improve release notes as 2.9.48 is missing there completely.
| try: | ||
| return self.update_config() | ||
| except Exception: | ||
| logger.exception("TLS files failed to push. Error in config update") | ||
| return False |
There was a problem hiding this comment.
Yeah.... this is what we saw with @beliaev-maksim yesterday on a troubleshooting. Tnx for the quick fix here!
Update snap