[DPE-3895] Handle get patroni health exception #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 81.08% 81.08%
=======================================
Files 10 10
Lines 2252 2252
Branches 362 362
=======================================
Hits 1826 1826
Misses 351 351
Partials 75 75 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Apr 1, 2024
| @@ -313,7 +313,7 @@ def get_patroni_health(self) -> Dict[str, str]: | |||
| timeout=API_REQUEST_TIMEOUT, | |||
| ) | |||
|
|
|||
| return r.json() | |||
| return r.json() | |||
There was a problem hiding this comment.
If the response can't be parsed, retry.
taurus-forever
approved these changes
Apr 2, 2024
| @@ -313,7 +313,7 @@ def get_patroni_health(self) -> Dict[str, str]: | |||
| timeout=API_REQUEST_TIMEOUT, | |||
| ) | |||
|
|
|||
| return r.json() | |||
| return r.json() | |||
marceloneppel
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to catch the exception in #419
There are already handlers for RetryErrors, but we do not try to parse the json response within the tenacity attempt. There may be more underlying issues here, since patroni isn't responding with a valid json.