Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2469] Add support for disabling the operator #412

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Mar 23, 2024

Issue

Bootstack needs a way to stop the charm events during a maintenance window.

Solution

Implemented the disable operation the same way as MySQL charms (canonical/mysql-k8s-operator#388 and canonical/mysql-operator#409).

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.96%. Comparing base (3b3e0f2) to head (ddf5e67).

Files Patch % Lines
src/charm.py 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   81.08%   80.96%   -0.12%     
==========================================
  Files          10       10              
  Lines        2252     2259       +7     
  Branches      362      363       +1     
==========================================
+ Hits         1826     1829       +3     
- Misses        351      354       +3     
- Partials       75       76       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marceloneppel marceloneppel changed the title Add support for disabling the operator [DPE-2469] Add support for disabling the operator Apr 2, 2024
@marceloneppel marceloneppel marked this pull request as ready for review April 2, 2024 18:25
@marceloneppel marceloneppel merged commit d90ecd3 into main Apr 3, 2024
49 checks passed
@marceloneppel marceloneppel deleted the dpe-2469-disable-operator branch April 3, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants