[MISC] Update snap, charm libs and switch away from psycopg2-binary #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragomirp
commented
Feb 28, 2024
•
dragomirp
commented
- Update snap
- Updated charm libs
- Remove psycopg2-binary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 10 10
Lines 2235 2235
Branches 360 360
=======================================
Hits 1816 1816
Misses 347 347
Partials 72 72 ☔ View full report in Codecov by Sentry. |
Comment on lines
+34
to
+35
| prime: | ||
| - lib/ |
There was a problem hiding this comment.
suggest maybe adding a comment that this dir is used in the charm.py shebang
There was a problem hiding this comment.
I think the plugin is simple enough and I would rather not rerun CI over a comment.
carlcsaposs-canonical
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.