[DPE-3570] Save one min on charm deploy (by skipping _on_upgrade_charm_check_legacy() on early stage) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
=======================================
Coverage 69.21% 69.21%
=======================================
Files 11 11
Lines 2865 2865
Branches 507 507
=======================================
Hits 1983 1983
Misses 781 781
Partials 101 101 ☔ View full report in Codecov by Sentry. |
|
For the history, from test logs: 1 minute for each unit to download SNAP |
…eck_legacy() The _on_upgrade_charm_check_legacy() was necessary to allow very old revision 228 refresh to the revision 336 (the revision 228 didn't have `pre-upgrade-check` action). It is no longer topical, but still is being called from __init__ of class PostgreSQLUpgrade() for each Juju event. Inside we are checking `if self.charm._patroni.member_started` which is causing one minute waiting timeout for patroni which is not yet even installed: > 13:19:04 DEBUG unit.postgresql/0.juju-log ops 2.9.0 up and running. > 13:19:04 INFO unit.postgresql/0.juju-log Running legacy hooks/install. > 13:19:05 DEBUG unit.postgresql/0.juju-log ops 2.9.0 up and running. > 13:19:05 DEBUG unit.postgresql/0.juju-log Charm called itself via hooks/install. > 13:19:05 DEBUG unit.postgresql/0.juju-log Legacy hooks/install exited with status 0. > 13:19:05 DEBUG unit.postgresql/0.juju-log Wait all units join the upgrade relation > 13:19:05 DEBUG unit.postgresql/0.juju-log Emitting Juju event install. > 13:19:53 INFO juju.worker.uniter.operation ran "install" hook (via hook dispatching script: dispatch) > 13:19:53 DEBUG unit.postgresql/0.juju-log upgrade:0: ops 2.9.0 up and running. > 13:19:54 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:19:57 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:00 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:03 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:06 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:09 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:12 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:15 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:18 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:21 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:24 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:27 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:30 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:33 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:36 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:39 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:42 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:45 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:48 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:51 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:54 DEBUG unit.postgresql/0.juju-log upgrade:0: Starting new HTTP connection (1): 10.172.136.223:8008 > 13:20:54 DEBUG unit.postgresql/0.juju-log upgrade:0: Emitting Juju event upgrade_relation_created. > 13:20:54 DEBUG unit.postgresql/0.juju-log upgrade:0: Persisting dependencies to upgrade relation data...
taurus-forever
force-pushed
the
alutay/speedup_deploy_1
branch
from
8aee81a to
24ed7c3
Compare
taurus-forever
changed the title
|
Superseded by #413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
installhook, before patroni is installed.Solution: