Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2904] Switch to self hosted runners #285

Merged
merged 41 commits into from
Nov 28, 2023
Merged

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Nov 15, 2023

Switch to Canonical hosted runners.

@@ -57,24 +57,24 @@ coverage = {extras = ["toml"], version = "^7.3.2"}
pytest = "^7.4.0"
pytest-asyncio = "^0.21.1"
jsonschema = "^4.19.1"
psycopg2 = {version = "^2.9.9", extras = ["binary"]}
psycopg2-binary = "^2.9.9"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No libpq on the runner.

@dragomirp dragomirp force-pushed the dpe-2904-self-hosted branch from 0f454f6 to c62d355 Compare November 18, 2023 02:32
marceloneppel
marceloneppel previously approved these changes Nov 27, 2023
taurus-forever
taurus-forever previously approved these changes Nov 28, 2023
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. LGTM.
  2. Please update CONTRIBUTION.md guilde to represent new way to run the test(s):
tox run -e integration -- 'tests/integration/ha_tests/test_restore_cluster.py' --group='1' -m 'not unstable' --model test

taurus-forever
taurus-forever previously approved these changes Nov 28, 2023
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tox run -e integration # integration tests is still wrong in CONTRIBUTION.md, isn't it?

@dragomirp
Copy link
Contributor Author

LGTM, but tox run -e integration # integration tests is still wrong in CONTRIBUTION.md, isn't it?

I tried and tox -e integration still collects all the tests. We should most probably add a HOWTO run individual suites, but that's out of scope IMHO.

- lint
- unit-test
uses: canonical/data-platform-workflows/.github/workflows/integration_test_charm.yaml@test-large
- build
uses: canonical/data-platform-workflows/.github/workflows/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi this is gh-hosted, not self-hosted

Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's the party begin!

@dragomirp dragomirp merged commit ccdec9b into main Nov 28, 2023
38 checks passed
@dragomirp dragomirp deleted the dpe-2904-self-hosted branch November 28, 2023 21:34
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* DO NOT MERGE test self-hsoted runners

* Remove groups

* Add group markers

* fix pythonpath

* Switch to relative imports

* Switch to binary psycopg2 for test deps

* Conditionally skip tests

* Bump timeouts

* Skipping fixtures and bump in timeouts

* Juju matrix

* Revert "Juju matrix"

This reverts commit 24c9f8c.

* Juju2 job

* Revert backup changes

* Bump timeouts

* Switch to dpw 6

* More timeout bumps

* Increase timeouts

* Bump dpw

* Depend on unit tests

* Increase timeouts

* Skip additional backup test when secrets are not accessible

* Even more timouts

* Retry getting password if no primary was found

* Timeouts

* Bump dpw

* Try to preenable plpython

* Add markers and cleanup tox ini

* Marks

* Switch to mainline workflow

* Bump actions

* Matrix integration

* Update contributing

* Use the right workflow

* Bump action

---------

Co-authored-by: Carl Csaposs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants