Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed #264

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 25, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
urllib3 (changelog) ==1.26.17 -> ==1.26.18 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-45803

urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.

From RFC 9110 Section 9.3.1:

A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.

Affected usages

Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.

Both of the following conditions must be true to be affected by this vulnerability:

  • If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON)
  • The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised.

Remediation

You can remediate this vulnerability with any of the following steps:

  • Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
  • Disable redirects for services that you aren't expecting to respond with redirects with redirects=False.
  • Disable automatic redirects with redirects=False and handle 303 redirects manually by stripping the HTTP request body.

Release Notes

urllib3/urllib3 (urllib3)

v1.26.18

Compare Source

====================

  • Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.

Configuration

📅 Schedule: Branch creation - "" in timezone Etc/UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title Update dependency urllib3 to v1.26.18 [SECURITY] Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed Oct 26, 2023
@renovate renovate bot closed this Oct 26, 2023
@renovate renovate bot deleted the renovate/pypi-urllib3-vulnerability branch October 26, 2023 16:53
@renovate renovate bot changed the title Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed Update dependency urllib3 to v1.26.18 [SECURITY] Oct 26, 2023
@renovate renovate bot reopened this Oct 26, 2023
@renovate renovate bot restored the renovate/pypi-urllib3-vulnerability branch October 26, 2023 22:36
@renovate renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch from ece63c1 to d6e0b69 Compare October 26, 2023 22:36
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #264 (d6e0b69) into main (ec64e16) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   78.92%   78.92%           
=======================================
  Files          10       10           
  Lines        2149     2149           
  Branches      349      349           
=======================================
  Hits         1696     1696           
  Misses        383      383           
  Partials       70       70           

@renovate renovate bot changed the title Update dependency urllib3 to v1.26.18 [SECURITY] Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed Nov 7, 2023
@renovate renovate bot closed this Nov 7, 2023
@renovate renovate bot deleted the renovate/pypi-urllib3-vulnerability branch November 7, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants