Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2789] update data-platform-workflows #263

Merged
merged 22 commits into from
Nov 1, 2023
Merged

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Oct 25, 2023

Update to latest workflows and refactor CI to more closely resemble MySQL's.

@dragomirp dragomirp changed the title Dpe 2789 update dpw [DPE-2789] update data-platform-workflows Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #263 (77eb3ae) into main (6790adc) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 77eb3ae differs from pull request most recent head a9f3330. Consider uploading reports for the commit a9f3330 to get more accurate results

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   78.98%   78.92%   -0.07%     
==========================================
  Files          10       10              
  Lines        2151     2149       -2     
  Branches      349      349              
==========================================
- Hits         1699     1696       -3     
- Misses        381      383       +2     
+ Partials       71       70       -1     

see 3 files with indirect coverage changes

@dragomirp dragomirp force-pushed the dpe-2789-update-dpw branch 2 times, most recently from 3e80172 to 624774c Compare October 28, 2023 14:24
@dragomirp dragomirp force-pushed the dpe-2789-update-dpw branch from 624774c to bf0e086 Compare October 28, 2023 14:31
@dragomirp dragomirp force-pushed the dpe-2789-update-dpw branch from cdfdbf5 to 422c8d0 Compare October 28, 2023 15:05
@dragomirp dragomirp force-pushed the dpe-2789-update-dpw branch from b054d89 to 49e8f80 Compare October 28, 2023 16:56
@dragomirp dragomirp force-pushed the dpe-2789-update-dpw branch 2 times, most recently from ee6a2fe to df36e8b Compare October 28, 2023 21:41
strategy:
fail-fast: false
max-parallel: 6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not needed based on Alex comments some time ago and also because we should move to self hosted runners later (which should have more runners available as I heard recently).

Comment on lines -19 to -20
@pytest.fixture(scope="module")
async def cloud_configs(ops_test: OpsTest) -> None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to backups

renovate.json Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most custom rules are dropped for now, will try to reenable what we need at a later date.

tox.ini Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poetry and shellcheck need to be installed separately.

@dragomirp dragomirp marked this pull request as ready for review October 30, 2023 11:39
.github/workflows/ci.yaml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Dragomir!

strategy:
fail-fast: false
max-parallel: 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not needed based on Alex comments some time ago and also because we should move to self hosted runners later (which should have more runners available as I heard recently).

@dragomirp dragomirp merged commit 1e73df9 into main Nov 1, 2023
33 checks passed
@dragomirp dragomirp deleted the dpe-2789-update-dpw branch November 1, 2023 00:07
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* Tweak workflows

* Initial pass

* Tweak conftest

* Move renovate configs

* Add wrapper

* Copy from mysql-k8s

* Linting

* Partial merge

* Saner marks

* Tweak excludes

* Bump dpw version

* Bump deps

* Tweak backup tests

* Conditional free space

* Revert "Conditional free space"

This reverts commit c4f72d2.

* Bump jira sync version

* Bump lock

* Remove schedule and call

* Bump libs and actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants