[DPE-2717] Copy dashboard changes from K8s and use the correct topology dispatcher #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragomirp
commented
Oct 12, 2023
•
dragomirp
commented
- Copy over dash changes from the K8s charm.
- Use the correct custom event dispatcher depending on the juju version
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 80.67% 80.72% +0.05%
==========================================
Files 10 10
Lines 1920 1925 +5
Branches 313 314 +1
==========================================
+ Hits 1549 1554 +5
Misses 317 317
Partials 54 54
|
dragomirp
changed the title
dragomirp
commented
Oct 12, 2023
Comment on lines
+103
to
+104
| if juju_version.major > 2: | ||
| run_cmd = "/usr/bin/juju-exec" |
There was a problem hiding this comment.
The command name changed in juju 3
dragomirp
force-pushed
the
copy-dashboards
branch
from
c633b35 to
11c1ee1
Compare
dragomirp
commented
Oct 12, 2023
Comment on lines
-44
to
-46
| }, { | ||
| "matchPackageNames": ["urllib3"], | ||
| "allowedVersions": "<2.0.0" |
There was a problem hiding this comment.
Botocore moved the pin
taurus-forever
approved these changes
Oct 13, 2023
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
…gy dispatcher (canonical#248) * Copy dashboard changes from K8s * Tweak exec command for the topology observer * Unit test * Bump libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.