Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPE-2617 autotune production profile #231

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

paulomach
Copy link
Contributor

Port of pg-k8s pr#260

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #231 (0064819) into main (ecd609c) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   80.71%   80.73%   +0.01%     
==========================================
  Files           9        9              
  Lines        1862     1869       +7     
  Branches      304      307       +3     
==========================================
+ Hits         1503     1509       +6     
  Misses        309      309              
- Partials       50       51       +1     
Files Coverage Δ
src/charm.py 73.40% <85.71%> (+0.11%) ⬆️

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add basic test here to make Codecov happy. Tnx!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should increment the lib version. I've created canonical/postgresql-k8s-operator#264 for k8s

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ufff..... we need an automated protection here on CI/CD. Good ideas are welcome!

Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paulo! LGTM.

@paulomach
Copy link
Contributor Author

I'm merging without tests end because the only change was a libpatch bump to be consistent with the k8s lib. (previous tests run was successful)

@paulomach paulomach merged commit 8ce428d into main Sep 26, 2023
8 checks passed
@paulomach paulomach deleted the feature/dpe-2617-autotune-production-profile branch September 26, 2023 14:51
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* auto tune based on memory

* increased coverage

* bump lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants