Skip to content

Commit

Permalink
Tweak renovate
Browse files Browse the repository at this point in the history
  • Loading branch information
dragomirp committed Nov 14, 2023
1 parent 08a189a commit 7ef169a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
"reviewers": ["dragomirp", "marceloneppel", "taurus-forever"],
"packageRules": [
// Later rules override earlier rules
{
"matchPackageNames": ["pydantic"],
"allowedVersions": "<2.0.0"
}, {
"matchPackageNames": ["python"],
"allowedVersions": "<3.11.0"
}
],
"regexManagers": [
{
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ on:
paths-ignore:
- 'tests/**'
- 'docs/**'
- renovate.json
- poetry.lock
- .github/renovate.json5
- pyproject.toml
- '.github/workflows/ci.yaml'
- '.github/workflows/lib-check.yaml'
Expand Down
2 changes: 1 addition & 1 deletion src/backups.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def _are_backup_settings_ok(self) -> Tuple[bool, Optional[str]]:
"Relation with s3-integrator charm missing, cannot create/restore backup.",
)

s3_parameters, missing_parameters = self._retrieve_s3_parameters()
_, missing_parameters = self._retrieve_s3_parameters()
if missing_parameters:
return False, f"Missing S3 parameters: {missing_parameters}"

Expand Down
2 changes: 1 addition & 1 deletion src/relations/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def set_up_relation(self, relation: Relation) -> bool:
"""Set up the relation to be used by the application charm."""
# Do not allow apps requesting extensions to be installed
# (let them now about config options).
required_extensions, disabled_extensions = self._get_extensions(relation)
_, disabled_extensions = self._get_extensions(relation)
if disabled_extensions:
logger.error(
f"ERROR - `extensions` ({', '.join(disabled_extensions)}) cannot be requested through relations"
Expand Down

0 comments on commit 7ef169a

Please sign in to comment.