[DPE-5324] Increase linting rules #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 75.48% 75.57% +0.09%
==========================================
Files 12 12
Lines 3121 3108 -13
Branches 475 464 -11
==========================================
- Hits 2356 2349 -7
+ Misses 622 620 -2
+ Partials 143 139 -4 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Oct 16, 2024
Comment on lines
+180
to
+182
| cursor.execute( | ||
| SQL("SELECT datname FROM pg_database WHERE datname={};").format(Literal(database)) | ||
| ) |
There was a problem hiding this comment.
Bandit checks don't like rendering directly in the SQL string.
dragomirp
commented
Oct 16, 2024
Comment on lines
+100
to
+107
| return not ( | ||
| not self.charm._patroni.member_started | ||
| and ( | ||
| (len(self.charm._peers.data.keys()) == 2) | ||
| or ( | ||
| "tls" not in self.charm.unit_peer_data | ||
| and any("tls" in unit_data for _, unit_data in self.charm._peers.data.items()) | ||
| ) |
dragomirp
commented
Oct 16, 2024
| @@ -28,6 +28,7 @@ | |||
| from constants import POSTGRESQL_LOGS_PATH, POSTGRESQL_LOGS_PATTERN, REWIND_USER, TLS_CA_FILE | |||
|
|
|||
| RUNNING_STATES = ["running", "streaming"] | |||
| PATRONI_TIMEOUT = 10 | |||
There was a problem hiding this comment.
Arbitrary timeout for REST calls. IIRC otherwise TCP defaults are used.
dragomirp
commented
Nov 9, 2024
| @@ -109,14 +108,14 @@ def __init__( | |||
| user: str, | |||
| password: str, | |||
| database: str, | |||
| system_users: List[str] = [], | |||
| system_users: Optional[list[str]] = None, | |||
There was a problem hiding this comment.
We can't use implicit union (list[str] | None) for compatibility with focal (Python 3.8)
dragomirp
commented
Nov 9, 2024
| @@ -10,7 +10,8 @@ | |||
| def main(): | |||
| """Main loop that calls logrotate.""" | |||
| while True: | |||
| subprocess.run(["logrotate", "-f", "/etc/logrotate.d/pgbackrest.logrotate"]) | |||
| # Command is hardcoded | |||
| subprocess.run(["/usr/sbin/logrotate", "-f", "/etc/logrotate.d/pgbackrest.logrotate"]) # noqa: S603 | |||
|
|
|||
| # Wait 60 seconds before executing logrotate again. | |||
| time.sleep(60) | |||
There was a problem hiding this comment.
We can most probably use pebble backoff to do the same
dragomirp
commented
Nov 9, 2024
Comment on lines
+224
to
+227
| patch( | ||
| "relations.async_replication.PostgreSQLAsyncReplication._get_unit_ip", | ||
| return_value="1.1.1.1", | ||
| ) as _get_unit_ip, |
There was a problem hiding this comment.
Fails on non-Ubutu hosts without the patch.
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
taurus-forever
approved these changes
Nov 12, 2024
marceloneppel
approved these changes
Nov 12, 2024
lucasgameiroborges
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more linting rules and change and suppress the reported issues. Added rules are: