-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4617] Add support for tracing with tempo_k8s #497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx!
Hi, @shayancanonical! Most of the errors in the async replication tests should be fixed by #526. It was not moved to review yet because another issue happened today when running on CI. Also, the update in the To merge this PR, you can revert the |
thanks for helping investigate the root cause of the failing test @marceloneppel. i will momentarily revert the charm lib and update this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 70.19% 70.23% +0.03%
==========================================
Files 10 10
Lines 2775 2785 +10
Branches 516 518 +2
==========================================
+ Hits 1948 1956 +8
- Misses 729 731 +2
Partials 98 98 ☔ View full report in Codecov by Sentry. |
Issue
We would like to be able to instrument our charm and generate traces to discover inefficiencies in charm code execution. The observability team has developed a charm for tempo that we would like to integrate with.
Solution
Integrate with the tempo charm
Considerations