-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-3199] Update secrets implementation #358
Conversation
d16bdc1
to
fcb677c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we pls-pls copy paste all those unittests I've added for secrets for VM?
I do rely on those whenever testing secrest modifications...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please close Judit requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the unittests, good 2 go :-)
* Update libs * Partially fixing unit tests * Bump agent version * Revive unit tests * Failing early secrets check * Revert tests * Judit's unittests --------- Co-authored-by: Judit Novak <[email protected]>
Update the charm to the secrets implementation in the VM charm.