Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3199] Update secrets implementation #358

Merged
merged 8 commits into from
Jan 22, 2024
Merged

[DPE-3199] Update secrets implementation #358

merged 8 commits into from
Jan 22, 2024

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Jan 15, 2024

Update the charm to the secrets implementation in the VM charm.

@dragomirp dragomirp marked this pull request as ready for review January 18, 2024 20:01
src/charm.py Show resolved Hide resolved
Copy link
Contributor

@juditnovak juditnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we pls-pls copy paste all those unittests I've added for secrets for VM?

https://github.com/canonical/postgresql-operator/pull/314/files#diff-0580ab9aef31b44580478eb270ec3422c5e6fef35df585fecb3a68317e246809

I do rely on those whenever testing secrest modifications...

src/charm.py Show resolved Hide resolved
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please close Judit requests.

Copy link
Contributor

@juditnovak juditnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the unittests, good 2 go :-)

@dragomirp dragomirp merged commit 85699e1 into main Jan 22, 2024
40 checks passed
@dragomirp dragomirp deleted the dpe-3199-secrets branch January 22, 2024 16:20
BON4 pushed a commit to BON4/postgresql-k8s-operator that referenced this pull request May 20, 2024
* Update libs

* Partially fixing unit tests

* Bump agent version

* Revive unit tests

* Failing early secrets check

* Revert tests

* Judit's unittests

---------

Co-authored-by: Judit Novak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants