[DPE-2844] New interface indico test and new legacy extensions test #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
force-pushed
the
dpe-2844-indico
branch
from
a602f50 to
a9a18bd
Compare
dragomirp
commented
Nov 17, 2023
Comment on lines
-40
to
-41
| APPLICATION_NAME = "postgresql-test-app" | ||
| METADATA = yaml.safe_load(Path("./metadata.yaml").read_text()) |
There was a problem hiding this comment.
We have those in the root helpers module
dragomirp
commented
Nov 17, 2023
There was a problem hiding this comment.
There's no special behaviour for extensions in the new interface, so just deploying indico and waiting to idle.
dragomirp
commented
Nov 17, 2023
Comment on lines
-118
to
-123
| - name: Select test secret usage | ||
| id: select-test-secrets | ||
| if: ${{ github.event.pull_request.head.repo.full_name != 'canonical/postgresql-k8s-operator' }} | ||
| run: | | ||
| echo Skipping tests using secrets | ||
| echo "mark_secrets=and not uses_secrets" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
New dpw would skip automatically so we no longer need this logic.
dragomirp
commented
Nov 17, 2023
There was a problem hiding this comment.
The test app has a legacy interface with extensions for PGB tests, so using that to replace indico.
marceloneppel
approved these changes
Nov 17, 2023
taurus-forever
approved these changes
Nov 21, 2023
marceloneppel
pushed a commit
that referenced
this pull request
Nov 22, 2023
…324) * New legacy extension test * Indico test * Remove not failing on blocks * Use version not hash Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
pushed a commit
that referenced
this pull request
Nov 22, 2023
…324) * New legacy extension test * Indico test * Remove not failing on blocks * Use version not hash Signed-off-by: Marcelo Henrique Neppel <[email protected]>
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
…anonical#324) * New legacy extension test * Indico test * Remove not failing on blocks * Use version not hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution