[DPE-2804] Conditionally skip backup tests #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
force-pushed
the
dpe-2804-conditional-backup-tests
branch
from
3a38557 to
7004e72
Compare
dragomirp
commented
Nov 1, 2023
Comment on lines
+83
to
+85
| async def test_none() -> None: | ||
| """Empty test so that the suite will not fail if all tests are skippedi.""" | ||
| pass |
There was a problem hiding this comment.
We should add local s3 tests (microceph? minio?) as a sanity check.
There was a problem hiding this comment.
JFYI, @paulomach has recently added microceph tests on MySQL, request details to reuse it.
dragomirp
commented
Nov 1, 2023
Comment on lines
+105
to
+107
| # preview and explicit preview are enabled for CPY001 | ||
| preview = true | ||
| explicit-preview-rules = true |
There was a problem hiding this comment.
Linting complains otherwise.
taurus-forever
approved these changes
Nov 1, 2023
Comment on lines
+83
to
+85
| async def test_none() -> None: | ||
| """Empty test so that the suite will not fail if all tests are skippedi.""" | ||
| pass |
There was a problem hiding this comment.
JFYI, @paulomach has recently added microceph tests on MySQL, request details to reuse it.
marceloneppel
approved these changes
Nov 2, 2023
marceloneppel
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Conditionally skip backup tests * Wrong step output * Bump libs Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Conditionally skip backup tests * Wrong step output * Bump libs Signed-off-by: Marcelo Henrique Neppel <[email protected]>
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
* Conditionally skip backup tests * Wrong step output * Bump libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Can't run the backup integration tests without accessing secrets
Solution
Skip tests if PR from a forked repo
Test external PR: #311