chore: fix ci warnings #1439
Merged
chore: fix ci warnings #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronCore864
requested review from
dimaqq and
james-garner-canonical
and removed request for
james-garner-canonical
dimaqq
approved these changes
Oct 21, 2024
benhoyt
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python version warnings and go cache warnings in github actions.
Closes #1346.
On the go cache warning: By default the cache is enabled, but in our case, since we only need go to install Pebble and there is no
go.sumfile, there is no need for the cache, see the logic in the code here. So I am disabling the cache explicitly, which should not make the actions run slower but should suppress the warnings.See a successful run here and there is no more warnings.