-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade ruff to v0.7.0 #1437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks. Regarding this issue / SIM115, unless I'm missing something, it looks like it's intentionally flagging those now, so I don't think we should have TODO comments on these, right?
We should just keep the noqa: SIM115
comments as this will be always on now.
I've opened #1440 to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why so few changes are required.
Perhaps it's because Tony already took care of a lot of stuff during the Scenario merge.
Or maybe it's an invitation for us re-enable some of the ignored codes?
Please check if there's some low-hanging fruit.
For example, it seems that C408 no longer needs to be ignored.
I suspect that using
For background: most of the ones that are in pyproject.toml as ignored (in the first section) we want to keep ignoring. There are a few that have comments indicating that we'd want to consider enabling them in the future. I think mostly those will be better as separate PRs, though. If there are It would be good to check if there are any new rules/sets that we should consider enabling, either here or separately. |
Per the discussion above, we are keeping Per discussion in today's standup, we agreed to merge this PR first and then handle the refactor (try to remove rules that are not hitting anything or only affect a few places) in a separate PR, see it here. |
Update linting rules with the latest ruff version 0.7.0. After upgrading ruff to the latest version [in this PR](#1437), some rules can be removed since they are not hitting any code, and some other rules can be relatively easily refactored.
Currently, we are using ruff 0.4.5 but recently 0.7.0 was released, this PR upgrades ruff to 0.7.0 for both formatting and linting.
Closes #1335.