test: fix type hinting on test_jujuversion tests #1011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JujuVersion's comparisons can be done against strings as well as other JujuVersions, so the type hints should reflect that.
For mocking the os.environ response, the type is dict(str, str) but I think to declare that we would need to define the dict, e.g:
And that looks considerably messier to my eyes and doesn't seem to really add value (so I've ignored the warning).
Partially addresses #1007