Skip to content

Commit

Permalink
With the benchmark tests in a separate folder, no need to change pypr…
Browse files Browse the repository at this point in the history
…oject.toml

Ideally, we would statically check these, like the other tests, but it does not seem super important for benchmarking tests. The issue is that there is an import after a sys.path manipulation, and pyright cannot figure that out, so complains about a lot of things. We do not want to have that charm on the path, and adjusting the path for pyright does not seem great either. Not clear what the cleanest solution is.
  • Loading branch information
tonyandrewmeyer committed Dec 18, 2024
1 parent b362f13 commit 34d4d73
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ builtins-ignorelist = ["id", "min", "map", "range", "type", "TimeoutError", "Con

[tool.pyright]
include = ["ops/*.py", "ops/_private/*.py", "test/*.py", "test/charms/*/src/*.py", "testing/src/*.py"]
exclude = ["test/test_benchmark.py"]
pythonVersion = "3.8" # check no python > 3.8 features are used
pythonPlatform = "All"
typeCheckingMode = "strict"
Expand Down

0 comments on commit 34d4d73

Please sign in to comment.