Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #186

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Update PR template #186

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4756573
Update PR template
arturo-seijas Aug 31, 2023
7d93b93
Merge branch 'main' into update-pr-template
arturo-seijas Aug 31, 2023
fc6ea1a
Merge branch 'main' into update-pr-template
arturo-seijas Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,13 @@ Applicable spec: <link>

<!-- The reason the change is needed -->

### Juju Events Changes
### Workflow Changes

<!-- Any changes to the juju events being observed (newly added, significantly modified or deleted) -->

### Module Changes

<!-- Any high level changes to modules and why (Service, Observer, helper) -->

### Library Changes

<!-- Any changes to charm libraries -->
<!-- Any high level changes to workflows and why -->

### Checklist

- [ ] The [charm style guide](https://juju.is/docs/sdk/styleguide) was applied
- [ ] The [contributing guide](https://github.com/canonical/is-charms-contributing-guide) was applied
- [ ] The changes are compliant with [ISD054 - Managing Charm Complexity](https://discourse.charmhub.io/t/specification-isd014-managing-charm-complexity/11619)
- [ ] The documentation is generated using `src-docs`
- [ ] The documentation for charmhub is updated.
- [ ] The PR is tagged with appropriate label (`urgent`, `trivial`, `complex`)
yanksyoon marked this conversation as resolved.
Show resolved Hide resolved

<!-- Explanation for any unchecked items above -->
Loading