Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional logic to allow CI and Make #252

Merged
merged 20 commits into from
Dec 19, 2024
Merged

Conversation

MichaelThamm
Copy link
Contributor

@MichaelThamm MichaelThamm commented Dec 15, 2024

TODO

Test the following cases:

  • Tox with static
  • Make without Scenario
  • Make with test failure

Fixes #249

This conditional logic ensures that we do not run Make if the test has failures. This also assumes that the whole test suite is ran for each repo even if there are no (e.g. scenario) tests which exist.

This would require repos that have Make, have each test type with a valid recipe. For example, if a repo does not have Scenario tests, the Make recipe would be:

scenario:
	echo "no scenario tests for this repo"

Copy link
Contributor Author

@MichaelThamm MichaelThamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if the Make recipe exists before executing

@MichaelThamm MichaelThamm marked this pull request as ready for review December 19, 2024 17:54
@MichaelThamm MichaelThamm requested a review from a team as a code owner December 19, 2024 17:54
@MichaelThamm MichaelThamm merged commit fa49daf into main Dec 19, 2024
1 check passed
@MichaelThamm MichaelThamm deleted the feature/conditional-ci branch December 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI green when scenario tests fail
3 participants