Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ci): specify workflow runner for integration tests #210

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skatsaounis
Copy link
Contributor

@skatsaounis skatsaounis commented Oct 7, 2024

Make integration workflow runner configurable, defaulting to its previous value ubuntu-latest.

Do so to enable specifying more powerful self-hosted runners by charms that need them for their integration tests.

Example: runs-on: [self-hosted, linux, X64, xlarge, jammy]

@skatsaounis skatsaounis requested a review from a team as a code owner October 7, 2024 07:52
@simskij simskij changed the title feat: specify workflow runner for integration tests feature(ci): specify workflow runner for integration tests Dec 6, 2024
@lucabello
Copy link
Contributor

@skatsaounis Could you point me to a successful run of this change? I'd love to double check we're not breaking other repos :D

@skatsaounis
Copy link
Contributor Author

@lucabello could you please push my branch to the canonical repo? If yes, I could try to run it and prove that is working. Because of GH action org secrets, I cannot run it from my personal fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants