fix race condition in privkey generation #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabello
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
Abuelodelanada
approved these changes
Feb 20, 2024
Abuelodelanada
pushed a commit
that referenced
this pull request
Feb 20, 2024
* fix race condition in privkey generation * fix static checks in other libs * tox fmt
Abuelodelanada
added a commit
that referenced
this pull request
Feb 20, 2024
* fix private key generation * add missing _on_upgrade * linting * fix race condition in privkey generation (#76) * fix race condition in privkey generation * fix static checks in other libs * tox fmt * update LIBPATCH --------- Co-authored-by: Luca Bello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When trying to use this library in Alertmanager, I got the following error:
In fact,
_on_config_changed()doesn't call_generate_privkey().The issue is that a race condition probably causes config-changed to arrive before certificates-relation-joined, which doesn't generate the private key beforehand.
Please note that calling the function multiple times isn't a problem as the function will just skip :)
Solution
Add a call to
_generate_privkey()in the_on_config_changed()handler.