Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error on duplicate ports passed to patch #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PietroPasotti
Copy link
Contributor

Issue

the service patch silently fails if you pass duplicate ports to it, say

                ports=[
                    ServicePort(name="svc1", port=1234, protocol="TCP"),
                    ServicePort(name="svc2", port=1234, protocol="TCP"),
                ],

Solution

catch that and raise an exception as that's user error

Context

this would have saved me a couple of hours of debugging this week

@simskij
Copy link
Member

simskij commented Nov 29, 2024

Since we're moving to using the ops facility for this, the change is no longer needed. We should instead look to deprecate this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants