Move private key from peer data to juju secrets #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Abuelodelanada
requested review from
sed-i,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
Abuelodelanada
changed the title
PietroPasotti
previously requested changes
Nov 23, 2023
sed-i
reviewed
Nov 28, 2023
lucabello
approved these changes
Jan 5, 2024
lucabello
dismissed
PietroPasotti’s stale review
I think the points have been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR adds a new cert_handler version that moves key and certs from peer relation to Juju secrets