Refresh CSR "whenever" needed #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldmitry
force-pushed
the
reconcile-logic
branch
from
de6156a to
fad79d8
Compare
PietroPasotti
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, if SANs changed, we'd refresh the CSR only on the events passed to
refresh_events. We should be doing that regardless of which event we're processing (as long as there was an initial CSR generated) since we might not know which specific events would trigger a SANs change.Solution
Add a "reconcile" logic in CertHandler constructor to refresh CSR if there has been any change to SANs.
Testing Instructions
run
tox -e scenario-manualUpgrade Notes
refresh_eventsis passed to CertHandler.