[cert handler] don't fail on vault.clear() failures #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abuelodelanada
approved these changes
Jun 19, 2024
sed-i
added a commit
that referenced
this pull request
Jun 19, 2024
* [cert handler] do not observe rel broken directly * codespell ignore assertIn * [cert handler] don't fail on vault.clear() failures (#100) --------- Co-authored-by: PietroPasotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #95
Solution
don't raise when calling
Secret.remove_all_revisionsfails with SecretNotFound.Context
Unclear exactly what's causing this, as the _SecretVaultBackend already catches SecretNotFound and initializes a fresh secret in that case. It's odd that two lines later info-get on that fresh secret raises SecretNotFound again.
Discussion with juju is ongoing to see whether we can find out what's going on.
Testing Instructions
Attempt to repro #95 and see if it's fixed