Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend fiveg_rfsim interface #64

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Dec 3, 2024

Description

This PR extends the fiveg_rfsim interface according to canonical/charm-relation-interfaces#202 by putting RFSIM address, SST and SD information to the relation data bag.

  • Validates Provider application data before putting the information to the relation data bag
  • Removes custom events and only uses standart charm events (relation joined, relation changed) to simplify the implementation
  • Expand unit tests for fiveg_rfsim interface

Dependencies

The implementation in the charm depends on fiveg_f1 interface as this interface is used to get the SST and SD data from CU charm. fiveg_rfsim relation should wait until data is retrieved through fiveg_f1 relation. #58 should be merged.

Note

fiveg_f1 interface can carry multiple PLMNs and each PLMN includes SST and SD.
Which SST and SD value should be sent to UE in the fiveg_rfsim relation data ?
After discussing this with @Gmerold , TE126 updated to use the first PLMN.
Fiveg_rfsim interface only used with UE simulator.
For real UE's, device group of slice includes the IMSI which can be associated with the related UE.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner December 3, 2024 12:15
@gatici gatici changed the title feat: Expand fiveg_rfsim interface feat: extend fiveg_rfsim interface Dec 3, 2024
@gatici gatici marked this pull request as draft December 3, 2024 12:16
@gatici gatici force-pushed the TELCO-1457-extend-5g-rfsim-interface branch from 83a3c6d to d3ea823 Compare December 3, 2024 13:38
@gatici gatici force-pushed the TELCO-1457-extend-5g-rfsim-interface branch from d3ea823 to f3a3517 Compare December 9, 2024 12:18
@gatici gatici marked this pull request as ready for review December 9, 2024 12:22
@gatici gatici requested review from patriciareinoso and a team December 9, 2024 12:23
lib/charms/oai_ran_du_k8s/v0/fiveg_rfsim.py Outdated Show resolved Hide resolved
lib/charms/oai_ran_du_k8s/v0/fiveg_rfsim.py Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-1457-extend-5g-rfsim-interface branch from e04ad0a to 2c49e66 Compare December 9, 2024 15:56
src/charm.py Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-1457-extend-5g-rfsim-interface branch from b17448f to 27ace70 Compare December 10, 2024 13:03
@gatici gatici force-pushed the TELCO-1457-extend-5g-rfsim-interface branch from 27ace70 to e49ae56 Compare December 10, 2024 13:06
Signed-off-by: gatici <[email protected]>
@gatici gatici merged commit ba70453 into main Dec 10, 2024
21 checks passed
@gatici gatici deleted the TELCO-1457-extend-5g-rfsim-interface branch January 6, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants