generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend fiveg_rfsim interface #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatici
changed the title
feat: Expand fiveg_rfsim interface
feat: extend fiveg_rfsim interface
Dec 3, 2024
gatici
force-pushed
the
TELCO-1457-extend-5g-rfsim-interface
branch
from
December 3, 2024 13:38
83a3c6d
to
d3ea823
Compare
gatici
force-pushed
the
TELCO-1457-extend-5g-rfsim-interface
branch
from
December 9, 2024 12:18
d3ea823
to
f3a3517
Compare
ghislainbourgeois
approved these changes
Dec 9, 2024
patriciareinoso
requested changes
Dec 9, 2024
gatici
force-pushed
the
TELCO-1457-extend-5g-rfsim-interface
branch
from
December 9, 2024 15:56
e04ad0a
to
2c49e66
Compare
patriciareinoso
approved these changes
Dec 10, 2024
patriciareinoso
requested changes
Dec 10, 2024
gatici
force-pushed
the
TELCO-1457-extend-5g-rfsim-interface
branch
from
December 10, 2024 13:03
b17448f
to
27ace70
Compare
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
gatici
force-pushed
the
TELCO-1457-extend-5g-rfsim-interface
branch
from
December 10, 2024 13:06
27ace70
to
e49ae56
Compare
patriciareinoso
approved these changes
Dec 10, 2024
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
patriciareinoso
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the fiveg_rfsim interface according to canonical/charm-relation-interfaces#202 by putting RFSIM address, SST and SD information to the relation data bag.
Dependencies
The implementation in the charm depends on fiveg_f1 interface as this interface is used to get the SST and SD data from CU charm. fiveg_rfsim relation should wait until data is retrieved through fiveg_f1 relation. #58 should be merged.
Note
fiveg_f1 interface can carry multiple PLMNs and each PLMN includes SST and SD.
Which SST and SD value should be sent to UE in the fiveg_rfsim relation data ?
After discussing this with @Gmerold , TE126 updated to use the first PLMN.
Fiveg_rfsim interface only used with UE simulator.
For real UE's, device group of slice includes the IMSI which can be associated with the related UE.
Checklist: