Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend fiveg_f1 interface library #53

Merged
merged 10 commits into from
Dec 2, 2024

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Nov 25, 2024

Description

This PR depends on canonical/charm-relation-interfaces#201

This PR extends the fiveg_f1 interface according to Orchestrating network configuration between the Core and the RAN

Information added to the provider side data bag:

  • tac
  • list of PLMNs

Each PLMN contains:

  • mcc
  • mnc
  • sst
  • sd (optional)

Custom events are removed to simplify the interface.
This PR hardcodes the values of the tac and plmns to align with the interface modification. Real values should come from the fiveg_core_gnb and this will be implemented in a new PR.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@patriciareinoso patriciareinoso changed the title feat: add v1 of fiveg_f1 interface library feat: extend fiveg_f1 interface library Nov 28, 2024
@patriciareinoso patriciareinoso force-pushed the TELCO-1456-extend-fiveg-f1 branch from 8e79316 to ed125f8 Compare November 29, 2024 15:31
@patriciareinoso patriciareinoso marked this pull request as ready for review November 29, 2024 15:32
@patriciareinoso patriciareinoso requested a review from a team as a code owner November 29, 2024 15:32
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriciareinoso patriciareinoso merged commit 40b6d1c into main Dec 2, 2024
27 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-1456-extend-fiveg-f1 branch December 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants