Skip to content

Commit

Permalink
add mindspore notebook in the default notebook list (#57)
Browse files Browse the repository at this point in the history
* add mindspore notebook in the default notebook list

* fix ci

Co-authored-by: Bowen Ma <[email protected]>
  • Loading branch information
iambowen and Bowen Ma authored Sep 7, 2022
1 parent a1a97fc commit c124e1b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions charms/jupyter-ui/src/spawner_ui_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ spawnerFormDefaults:
- kubeflownotebookswg/jupyter-pytorch-cuda-full:v1.6.0-rc.1
- kubeflownotebookswg/jupyter-tensorflow-full:v1.6.0-rc.1
- kubeflownotebookswg/jupyter-tensorflow-cuda-full:v1.6.0-rc.1
- swr.cn-south-1.myhuaweicloud.com/mindspore/jupyter-mindspore:v1.6.0-rc.1
imageGroupOne:
# The container Image for the user's Group One Server
# The annotation `notebooks.kubeflow.org/http-rewrite-uri: /`
Expand Down
2 changes: 1 addition & 1 deletion tests/test_charms.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ async def test_build_and_deploy(ops_test, lightkube_client, dummy_resources_for_
await ops_test.model.deploy(controller_charm, resources={"oci-image": controller_image_path})
await ops_test.model.deploy("admission-webhook", channel="latest/edge")
await ops_test.model.deploy("kubeflow-profiles", channel="latest/edge")
await ops_test.model.deploy("kubeflow-dashboard", channel="latest/edge", config={"profile": PROFILE_NAME})
await ops_test.model.deploy("kubeflow-dashboard", channel="latest/edge", trust=True)
await ops_test.model.add_relation("kubeflow-profiles", "kubeflow-dashboard")

# Wait for everything to deploy
Expand Down

0 comments on commit c124e1b

Please sign in to comment.