Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add logging lint checks to ruff #68

Merged
merged 2 commits into from
Dec 12, 2024
Merged

build: Add logging lint checks to ruff #68

merged 2 commits into from
Dec 12, 2024

Conversation

DanielArndt
Copy link
Member

Checks for some common logging patterns to avoid.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DanielArndt
build: Add logging lint checks to ruff
87d59a5 
Checks for some common logging patterns to avoid.
@DanielArndt

This comment was marked as resolved.

Sign in to view
@DanielArndt DanielArndt marked this pull request as ready for review December 12, 2024 18:06
@DanielArndt DanielArndt requested a review from a team as a code owner December 12, 2024 18:06
@DanielArndt DanielArndt merged commit 4e06bb8 into main Dec 12, 2024
8 checks passed
@DanielArndt DanielArndt deleted the ruff-logging-lint-checks branch December 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielArndt @gruyaume