Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we adapt the Notary K8s charm the the new Notary API. Doing so, we centralize the request creation and parsing using the new
_make_request
function.We also improve some struct and function names for standardization. For example:
get_certificate_requests_table
->list_certificate_requests
post_csr
->create_certificate_request
Why I added Grafana lint exclusions
The CI is now failing at the grafana lint stage for a reason unrelated to my change. The grafana dashboard linter recently added logql linting. They don't version the tool and we use the
latest
version, hence why our CI was passing and is now failing on Grafana lint.I added the following two Grafana lint exclusions:
We should likely address those in the future.
Checklist: