Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new notary api #43

Merged
merged 9 commits into from
Sep 27, 2024
Merged

chore: use new notary api #43

merged 9 commits into from
Sep 27, 2024

Conversation

gruyaume
Copy link
Contributor

@gruyaume gruyaume commented Sep 25, 2024

Description

Here we adapt the Notary K8s charm the the new Notary API. Doing so, we centralize the request creation and parsing using the new _make_request function.

We also improve some struct and function names for standardization. For example:

  • get_certificate_requests_table -> list_certificate_requests
  • post_csr -> create_certificate_request

Why I added Grafana lint exclusions

The CI is now failing at the grafana lint stage for a reason unrelated to my change. The grafana dashboard linter recently added logql linting. They don't version the tool and we use the latest version, hence why our CI was passing and is now failing on Grafana lint.

I added the following two Grafana lint exclusions:

  • target-logql-rule:
  • target-logql-auto-rule:

We should likely address those in the future.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: guillaume <[email protected]>
@gruyaume gruyaume requested a review from a team as a code owner September 25, 2024 18:56
src/charm.py Outdated Show resolved Hide resolved
@gruyaume gruyaume requested a review from kayra1 September 26, 2024 18:48
@gruyaume gruyaume merged commit 67b8868 into main Sep 27, 2024
8 checks passed
@gruyaume gruyaume deleted the dev-api branch September 27, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants