Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build for arm #28

Merged
merged 1 commit into from
Sep 13, 2024
Merged

chore: build for arm #28

merged 1 commit into from
Sep 13, 2024

Conversation

kayra1
Copy link
Collaborator

@kayra1 kayra1 commented Aug 23, 2024

Description

Currently, if we build and deploy this charm on ARM, the deployed charm has an incompatible workload. This PR attempts to fix that.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 changed the title fix: workload working in ARM architecture fix: workload not working in ARM architecture Aug 23, 2024
@kayra1 kayra1 changed the title fix: workload not working in ARM architecture chore: build for arm Sep 13, 2024
@kayra1 kayra1 marked this pull request as ready for review September 13, 2024 09:11
@kayra1 kayra1 requested a review from a team as a code owner September 13, 2024 09:11
Copy link
Contributor

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the efforts to build self-signed certificates on arm lead to frequent CI failures, I'm not eager to add this to notary as well honestly. Should we even attempt to build on arm for the time being?

@kayra1
Copy link
Collaborator Author

kayra1 commented Sep 13, 2024

Currently the efforts to build self-signed certificates on arm lead to frequent CI failures, I'm not eager to add this to notary as well honestly. Should we even attempt to build on arm for the time being?

The way I see it we either fix it or remove it from the workflow entirely. The reason we are getting arm errors is because we hadn't released it for gocert, and now that we have a new charm we had to release for it too. This morning I manually published this charm on arm, and from now on we should never get an ARM failure again.

@kayra1 kayra1 merged commit 54d63dd into main Sep 13, 2024
10 checks passed
@kayra1 kayra1 deleted the add-arm branch September 13, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants