Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skeleton #1

Merged
merged 23 commits into from
Jul 10, 2024
Merged

feat: Skeleton #1

merged 23 commits into from
Jul 10, 2024

Conversation

kayra1
Copy link
Collaborator

@kayra1 kayra1 commented Jun 28, 2024

This PR contains the small demo I wrote last friday as an example. It's a bit more than just the skeleton, but it's still a review-able chunk (ignoring the 2100 lines of boilerplate and lib code) that's a good starting point for this repo.

@kayra1 kayra1 requested a review from a team June 28, 2024 14:28
@kayra1 kayra1 marked this pull request as draft June 28, 2024 14:38
charmcraft.yaml Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/configs/key.pem Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from gruyaume July 1, 2024 12:25
@kayra1 kayra1 marked this pull request as ready for review July 1, 2024 12:25
@kayra1 kayra1 requested a review from ghislainbourgeois July 4, 2024 11:08
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, but I think this is a good skeleton to get started.

CONTRIBUTING.md Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@kayra1 kayra1 requested a review from ghislainbourgeois July 5, 2024 08:17
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/configs/config.yaml Show resolved Hide resolved
kayra1 and others added 8 commits July 9, 2024 12:19
Co-authored-by: Guillaume Belanger <[email protected]>
Co-authored-by: Guillaume Belanger <[email protected]>
Co-authored-by: Guillaume Belanger <[email protected]>
Co-authored-by: Guillaume Belanger <[email protected]>
Co-authored-by: Guillaume Belanger <[email protected]>
Co-authored-by: Guillaume Belanger <[email protected]>
Co-authored-by: Guillaume Belanger <[email protected]>
kayra1 and others added 2 commits July 9, 2024 12:21
Co-authored-by: Guillaume Belanger <[email protected]>
Co-authored-by: Guillaume Belanger <[email protected]>
@kayra1 kayra1 merged commit 0bc3dd1 into main Jul 10, 2024
1 check passed
@kayra1 kayra1 deleted the skelly branch July 31, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants