Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPE-1979 Avoid assumption that hostnames of members in cluster are resolvable #214

Merged
merged 6 commits into from
May 23, 2023

Conversation

shayancanonical
Copy link
Contributor

Issue

  1. We are assuming that hostnames of cluster members are resolvable from every cluster node (which holds true in lxc). However, it is an incorrect assumption for nodes in openstack
  2. We are setting the unit in BlockedStatus in the update-status event handler when there really isnt anything a user would need to do. The error is potentially recoverable since the update-status event handler will fire again (periodically)

Solution

  1. Set report_host for every member of the cluster. This will automatically set group_replication_local_address based off the value of report_host.
  2. Change the status to MaintenanceStatus

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #214 (47dcc17) into main (2a9839e) will decrease coverage by 0.30%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   63.83%   63.54%   -0.30%     
==========================================
  Files          12       12              
  Lines        2201     2219      +18     
  Branches      278      283       +5     
==========================================
+ Hits         1405     1410       +5     
- Misses        711      722      +11     
- Partials       85       87       +2     
Impacted Files Coverage Δ
src/charm.py 46.36% <18.51%> (-0.55%) ⬇️
lib/charms/mysql/v0/mysql.py 74.28% <21.42%> (-0.72%) ⬇️
src/mysql_vm_helpers.py 59.01% <100.00%> (+0.54%) ⬆️

Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/charm.py Outdated Show resolved Hide resolved
lib/charms/mysql/v0/mysql.py Outdated Show resolved Hide resolved
lib/charms/mysql/v0/mysql.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants