generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPE-1979 Avoid assumption that hostnames of members in cluster are resolvable #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
requested review from
delgod,
paulomach,
taurus-forever and
carlcsaposs-canonical
May 22, 2023 20:11
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 63.83% 63.54% -0.30%
==========================================
Files 12 12
Lines 2201 2219 +18
Branches 278 283 +5
==========================================
+ Hits 1405 1410 +5
- Misses 711 722 +11
- Partials 85 87 +2
|
paulomach
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
carlcsaposs-canonical
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
BlockedStatus
in the update-status event handler when there really isnt anything a user would need to do. The error is potentially recoverable since the update-status event handler will fire again (periodically)Solution
report_host
for every member of the cluster. This will automatically setgroup_replication_local_address
based off the value of report_host.MaintenanceStatus