-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: limit tenacity to 8.3 or earlier #443
base: main
Are you sure you want to change the base?
Conversation
Judging by the changes, the content is:
The repo maintainer may or may not want the re-lock because that bumps up a whole bunch of packages, though typically only micro bumps. P.S. given that old version restriction was The @paulomach should decide 🙇🏻 |
yes, please re-lock by checking out we'll update other dependencies in our renovate PRs |
reverted updates of unrelated packages & added back version floor to range in 5e8bec4 |
updated PR description to remove "fixes" on issue so that original issue stays open (so we fix our unit tests & remove the upper pin) |
@paulomach Should this be abandoned? re: #442 (comment) |
Issue
Tests do not pass with tenacity 8.4
Solution
Pin to < 8.4 (I assume you'll want to figure out what needs to be done to support 8.4, but for now this gets things to pass if re-locking).
Workaround for #442.